This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Add support for showing the donation type in Authorize #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,9 +127,13 @@ def onetime_purchase(self, donation, form): | |||
| api = self.get_api() | |||
| data = form.get_data_for_charge(donation) | |||
| donor = donation.donor | |||
| if donation.donation_type: | |||
There was a problem hiding this comment.
Is there a potential attribute error here? I feel like we saw that before – not sure if it's worth being more defensive by using hasattr.
There was a problem hiding this comment.
It's equal to None it looks like if it's not set.
|
+1 |
tswicegood
added a commit
that referenced
this pull request
Jul 18, 2012
Add support for showing the donation type in Authorize
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.