Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen aspect ratio not locked to video #11

Open
neodyma opened this issue Jul 5, 2018 · 1 comment
Open

Fullscreen aspect ratio not locked to video #11

neodyma opened this issue Jul 5, 2018 · 1 comment

Comments

@neodyma
Copy link

neodyma commented Jul 5, 2018

When going full screen on displays that are not 16:9, the video will be cropped to the display aspect ratio instead of using black bars. Thats probably because of the player using all of the display width (e.g. 3440px) and then cropping the vertical remains. Might be related to #3 ? Possible fix is locking the player to the vertical or horizontal width, depending on which is smaller compared to the video.

@jpjagt
Copy link
Contributor

jpjagt commented Jul 8, 2018

#12 fixes this by setting height: 100vh; on the <video> element, which then does the resizing correctly itself. If you could test it, though, that would be great :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants