Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen video goes halfway offscreen #3

Open
blaberry opened this issue May 18, 2018 · 5 comments
Open

Fullscreen video goes halfway offscreen #3

blaberry opened this issue May 18, 2018 · 5 comments

Comments

@blaberry
Copy link

The fullscreen Dash player seems to have some issues when the control bar goes off screen. Didn't happen before dark mode was implemented.

MBPr, 2017 model.
Chrome Canary Version 68.0.3398.0

screen shot 2018-05-18 at 22 55 24

@arn7av
Copy link
Owner

arn7av commented May 18, 2018

@blaberry I have heard that issue before, and I was surprised it was fixed for them after they restarted their MBP. Can you give it a full restart aswell, and get back with the result?

@blaberry
Copy link
Author

No dice, persists across reboots unfortunately

@arn7av
Copy link
Owner

arn7av commented May 19, 2018

@blaberry noted. While working for Theatre Mode, we will need to fix a lot of CSS issues w.r.t. grids and placements to fix the controlbar misbehaving in lot of scenarios. I am pondering on rewriting the full player using flexbox (the chat part is already written in flexbox after I found it was misbehaving in past). I am certain that the rewrite will fix these pesky issues aswell. Thanks a lot for reporting!

@blaberry
Copy link
Author

No problems, good luck!

@arn7av
Copy link
Owner

arn7av commented Jun 17, 2018

@blaberry it probably is fixed in 5515be8#diff-a4deaa0cd1a53c0cfe42859d99b7daa8R134. Would be awesome if you can give it a shot, and report back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants