Remove redundant indentation inside Run block #78

alshabalin · 2015-02-25T10:28:19Z

Suppose we have the following template:

%body
  - $options = [ 'One', 'Two', 'Three', 'Four', 'Five' ]

  - if (count($options))
    %ul
      - foreach ($options as $item)
        %li= $item
  - else
    %div No options!

Now it generates well-indented PHP code like this:

<body>
  <?php $options = [ 'One', 'Two', 'Three', 'Four', 'Five' ]; ?>
  <?php if (count($options)) { ?>
    <ul>
      <?php foreach ($options as $item) { ?>
        <li><?php echo htmlspecialchars($item,ENT_QUOTES,'UTF-8'); ?></li>
      <?php } ?>
    </ul>
  <?php } else { ?>
    <div>No options!</div>
  <?php } ?>
</body>

But in fact the output HTML code has some redundant indentation:

<body>
        <ul>
              <li>One</li>
              <li>Two</li>
              <li>Three</li>
              <li>Four</li>
              <li>Five</li>
          </ul>
  </body>

It would be nice to have something like this:

<body>
  <ul>
    <li>One</li>
    <li>Two</li>
    <li>Three</li>
    <li>Four</li>
    <li>Five</li>
  </ul>
</body>

This HTML code is much more pretty :)

I have fixed this issue, may be this will be useful for someone.

To the issue arnaud-lb#76 "Redundant indentation inside Run block"

alshabalin added 5 commits February 25, 2015 18:19

Remove redundant indentation inside Run block

71b4fe0

To the issue arnaud-lb#76 "Redundant indentation inside Run block"

Fixed mistake in arguments for write method

94c9ec6

Updated tests for removing redundant indentation in PHP

ff863e1

Updated tests for removing redundant spaces

9533669

Three tests updated

d57f3ce

arnaud-lb force-pushed the master branch from f2e64e5 to 86ebfbe Compare June 20, 2019 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove redundant indentation inside Run block #78

Remove redundant indentation inside Run block #78

alshabalin commented Feb 25, 2015

Remove redundant indentation inside Run block #78

Are you sure you want to change the base?

Remove redundant indentation inside Run block #78

Conversation

alshabalin commented Feb 25, 2015