Update Package.swift manifest to define RxInfiniteLayout product #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…target, allowing RxSwift-related classes and extensions to be imported via Swift Package Manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Package.swift manifest to define
RxInfiniteLayoutproduct and target, allowing RxSwift-related classes and extensions to be imported via Swift Package Manager.This continues to allow importing
InfiniteLayoutvia Swift Package Manager without anRxSwiftdependency, and optionally allows Rx support to be included by depending on the additionalRxInfiniteLayoutproduct, which depends onRxSwift,RxCocoaandRxDataSource.Because the Rx-related classes are in a separate library module, they must import the
InfiniteLayoutmodule. This also required more permissive (open) access toInfiniteCollectionViewandInfiniteDataSource.Also, because the
InfiniteLayoutpackage might not exist when importing this library via CocoaPods (or other dependency managers), I wrapped the import statements in conditional-compilation directives.