Add sep parameter in get_contributions() (#49)

NEWS.md

@@ -1,5 +1,7 @@
 # plume (development version)
 
+* `$get_contributions()` gains a new parameter `sep` that allows for finer control of how to separate contributors or roles (#49).
+
 * `$to_yaml()` now throws an error when invalid ORCID identifiers are found.
 
 * `Plume`'s parameter `by` is now working properly (#48).

R/plume.R

@@ -229,6 +229,7 @@ Plume <- R6Class(
     #' @param literal_names Should literal names be used?
     #' @param divider Separator used to separate roles and authors. Uses `": "`
     #'   by default.
+    #' @param sep Separator used to separate roles or authors.
     #' @param sep_last Separator used to separate the last two roles or authors
     #'   if more than one item is associated to a role or author.
     #' @return A character vector.
@@ -239,6 +240,7 @@ Plume <- R6Class(
         dotted_initials = TRUE,
         literal_names = FALSE,
         divider = ": ",
+        sep = ", ",
         sep_last = " and "
     ) {
       role <- private$pick("role")
@@ -261,6 +263,7 @@ Plume <- R6Class(
       }
       out <- summarise(out, !!pars$var := enumerate(
         contribution_items(pars, by_author, alphabetical_order),
+        sep = sep,
         last = sep_last
       ), .by = all_of(pars$grp_var))
       if (are_credit_roles(private$roles) || private$crt) {

tests/testthat/test-get-contributions.R

@@ -32,6 +32,10 @@ test_that("get_contributions() return authors' contributions", {
     aut$get_contributions(by_author = FALSE, alphabetical_order = TRUE),
     c("a: P.-P.P., R.R. and Z.Z.", "b: Z.Z.")
   )
+  expect_equal(
+    aut$get_contributions(by_author = FALSE, sep = "; "),
+    c("a: Z.Z.; R.R. and P.-P.P.", "b: Z.Z.")
+  )
   expect_equal(
     aut$get_contributions(by_author = FALSE, sep_last = " & "),
     c("a: Z.Z., R.R. & P.-P.P.", "b: Z.Z.")