Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partial match like column: abc_def_ghi -> prop: abcGhi.defGhi #678

Merged
merged 1 commit into from Aug 27, 2019

Conversation

sndyuk
Copy link
Contributor

@sndyuk sndyuk commented Aug 24, 2019

The partial matcher has allowed the matching:

  • abc_def_ghi -> abc.defGhi

This change is going to allow the matching too:

  • abc_def_ghi -> prop: abcGhi.defGhi

Since I want to map the case below without defining specific mapping:
Columns on the table:

scheduled_start_date
scheduled_end_date

Entity

class Entity {
  DateRange scheduledDate;
}
class DateRange {
  Date startDate;
  Date endDate;
}

Please consider to merge it. Thanks!

@arnaudroger
Copy link
Owner

Thanks I’ll have a look

@arnaudroger
Copy link
Owner

I'll try to get that in, but right now it's breaking the tests

@arnaudroger arnaudroger merged commit 0229239 into arnaudroger:master Aug 27, 2019
@arnaudroger
Copy link
Owner

merged as 18d5c2b a few fix for stack overflow and some clean up

@arnaudroger
Copy link
Owner

that's been released with version 8.0.0, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants