-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a2sketch node limit #12
Comments
Now this gets interesting... My findings so far:
Possible solutions: solution a) seems more promising, but has some drawbacks... |
I just found out, that there might be a problem wit duplicate ids in the generated html: So, solution b) is not an option, I thing... |
Yes the IDs are the most likely reason this is happening (and also why the
arrows in particular seem to be affected). It's great news too, because a
low, hard limit on SVG paths would be a much harder nut to crack...
…On Sun, 20 Jan 2019, 15:32 Arne Hilmann ***@***.*** wrote:
I just found out, that there might be a problem wit duplicate ids in the
generated html:
every a2sketch image has id for nearly every g, text, ... element, for
example "id=Pointer".
When changing this id to "id=Pointer1" and reference it in the line part
of the svg, the arrow suddenly gets plotted.
So, solution b) is not an option, I thing...
but there is another possible solution:
c. a2sketch converts ids of svg elements in unique ids (somehow)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtiwA42QE26O2x8j96-u3HRkGwFfKL7ks5vFIwBgaJpZM4aIb-y>
.
|
Please give |
YES it works perfectly, thanks! |
Snap: the new id-rewrite mechanism in how likely is it to include the same graphics multiple times? |
Never - that's an edge case you shouldn't have to support :)
…On Tue, 22 Jan 2019, 10:33 Arne Hilmann ***@***.*** wrote:
Snap: the new id-rewrite mechanism in 0:12 works when including different
svgs, *but* it still results in same ids when including the exactly same
graphics again and again (like in your showcase).
how likely is it to include the same graphics multiple times?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtiwGKpSmW2GAJo7QS-iLQcLe3PTDqIks5vFuj8gaJpZM4aIb-y>
.
|
The number of lines in a2sketch drawings seems to hit a limit in Chrome and thus the PDF output. (See sample
slides.md
at end.)If the issue is the number of SVG nodes permitted in a single document - could the number of lines be configurable? If the precision value is increased, one or two lines for each edge might be enough for some drawings? If that's not possible - much though I prefer SVG, a PNG output might solve the problem?
I'm not sure BTW that this issue is about the number of nodes. I just know it's reproducible and means my decks only work in Firefox at the moment - and not in PDF.
In the following file, the fourth a2sketch drawing is the first that lacks arrow tips (although they are of course present in the rendered image).
Apologies for overlong sample document...
title: mytitle
pdf: myfile.pdf
slideNumber: true
controls: false
transition: slide
backgroundTransition: fade
A2SKETCH
A2SKETCH 2nd
A2SKETCH 3rd
A2SKETCH 4th
The text was updated successfully, but these errors were encountered: