Add markdeck script #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnehilmann
reviewed
Oct 1, 2019
| @@ -4,6 +4,7 @@ set -ue | |||
|
|
|||
| BUILD=deck | |||
| VERSION=0.1 | |||
| PORT=8080 | |||
There was a problem hiding this comment.
But this is still static, isn't it?
I would expect something like PORT=${1:-8080} or PORT=${PORT:-8080} or the like...
and: gets the correct port number displayed in the mark deck console (I mean at the end of the loop output)?
|
Yes, it's still static because of the very reason that the change would need to be transported to the docker image to generate the right message. I left that for another pull request. |
|
:o) That problem sounds familiar... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a script that includes the
docker-compose.ymlconfiguration and replaces thescaffold,startandstopscripts. Furthermore, it cuts down the boilerplate in the presentation folder by leaving it solely for the presentation and the./deckbuild folder.