Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Picture-in-Picture actions into the Google Meet page directly #17

Closed
arnellebalane opened this issue Jan 7, 2022 · 0 comments · Fixed by #20
Closed

Move Picture-in-Picture actions into the Google Meet page directly #17

arnellebalane opened this issue Jan 7, 2022 · 0 comments · Fixed by #20
Assignees
Labels
enhancement New feature or request

Comments

@arnellebalane
Copy link
Owner

Basically a Chrome update now requires requestPictureInPicture calls to require a user gesture. So we can't call it now from the popup window of the extension. We need to move the buttons that enable Picture-in-Picture directly into the page itself so the user needs to click on it.

The current idea is to add a Picture-in-Picture button in each video in the call, and the user will click on the button for participant that they want to place in a PiP window. We will also phase out the PiP extension popup UI.

@arnellebalane arnellebalane added the enhancement New feature or request label Jan 7, 2022
@arnellebalane arnellebalane self-assigned this Jan 7, 2022
arnellebalane added a commit that referenced this issue Jan 23, 2022
This is only to get a user gesture before showing the PiP. Proper
solution should be done in
#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant