Changed affected-vars function to work with newer versions of clojure.tools.namespace.
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2020 10:04
….namespace. - Works with tools.namespace >= 0.3. - The function now uses `scan-dirs` instead of deprecated `scan`, whenever it can. - Properly accounts for reloading if `refresh-dirs` is set with `clojure.tools.namespace.repl/set-refresh-dirs` function. - Note that with newer versions of tools.namespace, setting `refresh-dirs` is mandatory in some cases like this: clojure-emacs/cider#2686
|
Hi Titon, I like it, thanks for this! Could you update the docstring of the |
|
Thank you for quick feedback! I added two new commits, implementing your requests. By the way, I am using mount-lite to manage and gracefully reload states inside the most significant peace of software in our company. Keep up the good work! |
|
Released as 2.2.1. Sorry for the delay in merging this. Once again, thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clojure.tools.namespace >= 0.3.scan-dirsinstead of deprecatedscan, whenever it can.refresh-dirsis set withclojure.tools.namespace.repl/set-refresh-dirsfunction.refresh-dirsis mandatory in some cases like this: CIDER repl doesn't work with clojure.tools.namespace.repl/refresh classpath clojure-emacs/cider#2686