fix rename action && allow to replace default settings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow to replace default settings
|
Thanks. Please remove the comment above |
revert composer.json
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| class TreeController extends Controller | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
Please remove this linebreak too.
|
And linebreak after class definition. |
| @@ -197,4 +197,4 @@ protected function getModel($paramName = null, $createIfNotFound = false) | |||
|
|
|||
| return $model; | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
This style change is redundant too. I guess it's caused by IDE.
There was a problem hiding this comment.
Yes, IDE doing it. But what is wrong now? I don't see linebreak
There was a problem hiding this comment.
Maybe extra spaces or you removed linebreak at the very end.
There was a problem hiding this comment.
It wasn't included in your first commit. Revert this changes via history or restore file to original condition and apply your fixes again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when rename node.
Add feature allowing to replace settings