Remove the "details by default" setting/feature, fixes #21

dal.coffee

@@ -39,13 +39,12 @@ module.exports =
     Account
       .findOne()
       .where('_id', username)
-      .select('nickname details is_new firstrun updated migrate')
+      .select('nickname is_new firstrun updated migrate')
       .exec cb
 
   update_settings: (username, settings, cb) ->
     Account.update _id: username,
       nickname: settings.nickname
-      details: settings.details
       firstrun: settings.firstrun
       migrate: settings.migrate,
       cb

static/js/models.js

@@ -222,7 +222,7 @@ Status = Backbone.Model.extend({
 
 });
 
-// Represents a user's account details and settings
+// Represents a user's account settings
 // This model is a singleton -- there should be only
 // one instance of it per account.
 Settings = Backbone.Model.extend({

static/js/views.js

@@ -82,7 +82,6 @@ SettingsView = Backbone.View.extend({
     var that = this;
     this.model.save({
       nickname: this.$("#nickname").val(),
-      details: this.$("#details").is(':checked')
     },
     {
       error: function (model, errors) {
@@ -102,7 +101,6 @@ SettingsView = Backbone.View.extend({
 
   render: function () {
     var context = {
-      details: this.model.get('details'),
       nickname: this.model.get('nickname')
     };
     this.$(".modal-body").html(this.template(context));
@@ -475,11 +473,12 @@ AssignmentView = Backbone.View.extend({
     }
 
     // Only show details if we should be
+    // TODO: Recheck this logic
     if (this.showing_details !== null) {
       if (this.showing_details === true) {
         this.showDetails();
       }
-    } else if (settings.get('details') || app.showing_details) {
+    } else if (app.showing_details) {
         this.showDetails();
     }
 

test/jbha.test.coffee

@@ -39,7 +39,6 @@ describe "dal", ->
     _id: String(Math.random())
     nickname: "Dr. " + Math.random()
     firstrun: false
-    details: true
 
   describe "create", ->
     it 'should create without error', (done) ->
@@ -65,7 +64,6 @@ describe "dal", ->
         should.not.exist err
         settings.nickname.should.equal mock_settings.nickname
         settings.firstrun.should.equal mock_settings.firstrun
-        settings.details.should.equal mock_settings.details
         settings.is_new.should.equal true
         done()
 

views/templates/settings.handlebars

@@ -7,14 +7,5 @@
         <span class="help-inline">This doesn&rsquo;t affect anything other than your ego.</span>
       </div>
     </div>
-    <div class="control-group">
-      <label class="control-label">Details by default</label>
-      <div class="controls">
-        <label class="checkbox">
-          <input type="checkbox" id="details" {{#if details}} checked {{/if}}>
-          <p class="help-inline">This is the just the default when you log in. You can toggle details from the Options menu whenever you want.</span>
-        </label>
-      </div>
-    </div>
   </fieldset>
 </form>