Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added userInfo and changed interface for request execution #4

Merged
merged 2 commits into from
Mar 26, 2018

Conversation

JFejza
Copy link
Collaborator

@JFejza JFejza commented Mar 26, 2018

This is a convenience change on interface for request to enable configuration with userInfo dictionary
Issue: #3

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #4 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   90.14%   90.15%   +<.01%     
==========================================
  Files          31       31              
  Lines        2091     2103      +12     
==========================================
+ Hits         1885     1896      +11     
- Misses        206      207       +1
Impacted Files Coverage Δ
VoxTests/DataSource/PaginationSpec.swift 82.41% <100%> (ø) ⬆️
...ox/Plugins/Alamofire/JSONAPIClient_Alamofire.swift 97.91% <100%> (ø) ⬆️
Vox/Core/Networking/Class/Request.swift 74.28% <50%> (-0.72%) ⬇️
VoxTests/DataSource/DataSourceSpec.swift 86.89% <70.58%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02efd5...5784b44. Read the comment docs.

@aronbalog aronbalog merged commit ca79f5d into aronbalog:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants