Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom request with userInfo #3

Closed
JFejza opened this issue Mar 26, 2018 · 4 comments
Closed

Support for custom request with userInfo #3

JFejza opened this issue Mar 26, 2018 · 4 comments
Assignees
@aronbalog
Labels
enhancement New feature or request

Comments

@JFejza
Copy link
Collaborator

JFejza commented Mar 26, 2018

Add userInfo dictionary for custom configuration of request
@JFejza JFejza mentioned this issue Mar 26, 2018
Merged
@aronbalog
Copy link
Owner

aronbalog commented Mar 26, 2018 •
edited

@JFejza It would be better if we call executeRequest with userInfo argument instead of Request. As Request is an internal object (sort of), it could be confusing for others to see request in Client implementation.

@JFejza
Copy link
Collaborator Author

JFejza commented Mar 26, 2018

Sure, I agree, I'll change it and update the PR

@JFejza
Copy link
Collaborator Author

JFejza commented Mar 26, 2018

Updated PR

@aronbalog
Copy link
Owner

Merged.

@aronbalog aronbalog self-assigned this Mar 26, 2018
@aronbalog aronbalog added the enhancement New feature or request label Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aronbalog aronbalog

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aronbalog @JFejza