Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amaze File Manager disabled on Fdroid #1684

Closed
YamiYukiSenpai opened this issue Sep 16, 2019 · 55 comments
Closed

Amaze File Manager disabled on Fdroid #1684

YamiYukiSenpai opened this issue Sep 16, 2019 · 55 comments
Labels
Bounty Issue-Severe (high) Showstopper issues that require immediate attention
Milestone

Comments

@YamiYukiSenpai
Copy link

YamiYukiSenpai commented Sep 16, 2019

Currently Amaze is disabled on fdroid for the reason that it's using a few proprietary libraries. This issue is focused at providing an alternative / removing those libraries so that fdroid servers can build Amaze File Manager


This now has a bounty, here.

Please claim after a PR fixing this issue is accepted.
Remember that you can also back the issue adding to the bounty!

@ghost
Copy link

ghost commented Sep 21, 2019

This. Why is the F-Droid version so behind in updates?

F-Droid version: 3.3.2

Play Store version: 3.3.4.79

@EmmanuelMess EmmanuelMess added the Issue-Severe (high) Showstopper issues that require immediate attention label Sep 21, 2019
@NishaYume
Copy link

Hello want to know when will be updated the F-Droid version too.

@EmmanuelMess
Copy link
Member

It should be automatically updated...

@flocke
Copy link

flocke commented Oct 2, 2019

The newest F-Droid builds fail because they detect cloudrail in the build.gradle file. Which is strange, I believe it has been there before as well...

@ravilov
Copy link

ravilov commented Oct 2, 2019

Perhaps cloudrail has been blacklisted by F-Droid in the meantime?
I too am looking forward to this getting resolved.
For reference, here's a link to the latest fdroid build log:
https://f-droid.org/wiki/page/com.amaze.filemanager/lastbuild

@VishalNehra
Copy link
Member

Opened an issue with fdroid, hope they give a solution to this.

https://gitlab.com/fdroid/fdroiddata/issues/1817

@ClockGen
Copy link

ClockGen commented Oct 22, 2019

@VishalNehra Cloudrail was indeed blacklisted since the last amaze update. https://gitlab.com/fdroid/fdroidserver/commit/b3754af137761b6cd427601a9131ea033199c4d4
The library itself was discontinued though, and cloudrail now focuses on something completely different (I dont know if cloudrail blacklist is connected to this or not).
As per F-Droid's policy, all libraries should be open source too, and if it was included before it was probably overlooked, or the library wasn't proprietary.

Is it possible to remove cloudrail for f-droid build flavor?

@EmmanuelMess
Copy link
Member

Is it possible to remove cloudrail for f-droid build flavor?

I think we need it to connect to the cloud.

@licaon-kter
Copy link

licaon-kter commented Nov 1, 2019

CloudRail now entirely focuses on connecting industrial sensors to AWS, Azure, Google IoT and many more to realize IIoT projects.

@EmmanuelMess ...I don't see an issue with a F-Droid version that can't handle clouds.

@ravilov
Copy link

ravilov commented Nov 1, 2019

I personally barely use cloud storage at all, none of which through Amaze, so I don't think I'd care too much if the functionality was gone from the F-Droid build. :)

Alternatively, we could try and find a free replacement lib with the same or similar functionality. I'm sure there's at least something out there.

@EmmanuelMess
Copy link
Member

EmmanuelMess commented Nov 2, 2019

Maybe we should create our own fork, instead of adding more differences between the Play and FDroid versions.

Edit: Where is the cloudrail source?

@licaon-kter
Copy link

Edit: Where is the cloudrail source?

Nice try, from what I see it wasn't a FOSS thing so no joy.

Yes, F-Droid trusted that maven repo to include only FOSS libs but that's was not an actual requirement.

@andersonvom
Copy link

Not sure if it's related, but fdroid is warning about the source code not being available:

This app has features you may not like: NoSourceSince

@licaon-kter
Copy link

@andersonvom yes, related, there's no source that F-Droid can build from only FOSS components (this source and its dependencies)

@EmmanuelMess
Copy link
Member

Update: last release on FDroid is now 3.1.2 RC1 (2yrs old, and there were 4 release candidates for that version).

@532910
Copy link

532910 commented Dec 13, 2019

Switched to https://github.com/zhanghai/MaterialFiles
Unsubscribing

@keunes
Copy link

keunes commented Dec 22, 2019

@EmmanuelMess ...I don't see an issue with a F-Droid version that can't handle clouds. [@licaon-kter]

I must say I second this. AntennaPod (which I'm active for) also had disabled one feature as a library was not FOSS. I'd rather have Amaze in the default F-Droid repository without cloud support than not have Amaze at all (I don't care for cloud support as I don't use it).

Maybe we should create our own fork, instead of adding more differences between the Play and FDroid versions.

Is an option indeed, but it might not be great for discoverability for potential new users.

@hman2
Copy link

hman2 commented Dec 26, 2019

Is it possible to remove cloudrail for f-droid build flavor?

I think we need it to connect to the cloud.

To which cloud?

Cloud support per se does not have to mean you have to get proprietary, as there are open source cloud implementations, Own Cloud for instance.

If this library is just used to access one specific, proprietary cloud, could this feature be separated into a plug-in that than will get "blacklisted" on F-Droid, but still available on the Play Store? I guess the entire cloud software accessed here is not avaible on F-Droid, so it would do no harm to separate its access into a plugin...

If it is just to have a cloud option for Amaze users, then I guess Own Cloud might be sufficient...

Also, I just followed the thread about WHY Amaze got blacklisted, because it uses CloudRail. There I found that CloudRail is also discontinued! I would say that for security reasons Amaze should NOT rely on cloud code that does not get security updates. That could become a security threat in the future. And if the proprietary cloud that should have been accessed by Amaze happens to be Dropbox, in this discussion there is mention of an open source SDK for Dropbox.

https://gitlab.com/fdroid/fdroiddata/issues/1817
https://github.com/dropbox/dropbox-sdk-java

Update: About the CloudRail Universal API:
https://developers.cloudrail.com/universal-api/
"This product has been discontinued as of March 1st 2019."

@mihawk90
Copy link

mihawk90 commented Jan 2, 2020

F-Droid version: 3.3.2

Maybe I'm blind but I'm not even seeing that... On the website the last version seems to be from 2017:

https://f-droid.org/packages/com.amaze.filemanager/

Hence why it also has the NoSourceSince Anti-Feature

@licaon-kter
Copy link

@mihawk90 Yes, we went back to the last version that was entirely FOSS, is that old? Maybe...

@mihawk90
Copy link

mihawk90 commented Jan 2, 2020

Ah well, must have overlooked that above. Thanks

@VishalNehra
Copy link
Member

Cloudrail indeed is outdated, but the APIs seem to be working fine till now. And the plugin is generating revenue for us. Creating a separate flavour for fdroid will require lots of codebase changes, basically a copy of each and every file. It's simply not worth it.
As for using only open source cloud services sdk, we do not currently have any time/resources to work on the same.

@keunes
Copy link

keunes commented Jan 6, 2020

I don't know anything about coding, but gradle flavours seemed to be the solution for a similar (free/non-free/F-drod) issue with AntennaPod: AntennaPod/AntennaPod#1959 Maybe that could be a solution for Amaze as well (?)

@wuniversales
Copy link

Why not create an AmazeFileManager repository for fdroid?

@VishalNehra
Copy link
Member

@keunes we've been using gradle flavours in past (G+ profile picture for nav bar feature), but in this scenario, we'll have to practically maintain identical file for almost whole source code in fdroid flavour. Would be very difficult to maintain.

@TakuyaSama
Copy link

Hi,

I've been reading a little bit about all this thing and i would like to know what's going to happen, i jut got tired to have the old Amaze File Manager 3.1.2 RC1 (the latest version available on F-Droid, which is almost 3 years old), and i just installed the latest version today (3.4.1) because i couldn't even install the APKs from Amaze, really limited options, etc.

I read (if i remember correctly at the GitLab discussion/issue dedicated to this), that the Amaze File Manager developer team would be developing a home made implementation of the cloud library that's causing all the mess (i suppose that would be FOSS, of course), and if i could know what about the status of it.

Thank you very much for your great efforts and work, i really love this fantastic app, to me (excepting for the limited to pay version cloud features), the best file manager (FOSS) for Android by far.

Bests ^^.

@VishalNehra
Copy link
Member

@TakuyaSama yes it's currently being developed. Last I heard from @EmmanuelMess Onedrive was done (except upload). You can join our Telegram channel to stay updated
https://t.me/joinchat/NNFgWxQUB8fFE3yCsC0w4g

@EmmanuelMess
Copy link
Member

Can we follow this work somewhere? :)

Yes at https://github.com/TeamAmaze/LaputaCloudsLib.

@keunes
Copy link

keunes commented Jan 8, 2022

Yes at https://github.com/TeamAmaze/LaputaCloudsLib.

Thanks for sharing that @EmmanuelMess. But oof - that looks like a massive work still. The best of luck with that!

@VishalNehra VishalNehra changed the title Saw that you updated Amaze twice, but F-Droid hasn't been updated Amaze File Manager disabled on Fdroid Aug 1, 2022
@VishalNehra
Copy link
Member

fyi, this issue now has a bounty, @linsui
https://app.bountysource.com/issues/80471358-amaze-file-manager-disabled-on-fdroid

@linsui
Copy link

linsui commented Aug 1, 2022

Thanks! 😂

@VishalNehra
Copy link
Member

@linsui we've release 3.8 please trigger fdroid build

@linsui
Copy link

linsui commented Sep 16, 2022

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11746 Amaze will be back on F-Droid in 2-3 days.

@VishalNehra VishalNehra added this to the v3.8 milestone Sep 16, 2022
@shuvashish76
Copy link
Contributor

Live on F-Droid 🎉
Badge: https://gitlab.com/fdroid/artwork/tree/master/badge#badge

@linsui
Copy link

linsui commented Sep 18, 2022

The badge is always there. 🤣

@VishalNehra
Copy link
Member

Alright, we're up
https://f-droid.org/packages/com.amaze.filemanager/
I think we're good to close this now.
@TranceLove @EmmanuelMess please confirm.

@EmmanuelMess
Copy link
Member

Alright, we're up f-droid.org/packages/com.amaze.filemanager I think we're good to close this now. @TranceLove @EmmanuelMess please confirm.

Confirmed!

@TranceLove
Copy link
Collaborator

Confirmed. Thanks everyone for helping on this.

@VishalNehra
Copy link
Member

@linsui just noticed, there's no icon for Amaze on its fdroid page is that something that'll be automatically fixed?
Also, can you confirm if you got the Bounty amount for this?

@shuvashish76
Copy link
Contributor

No such icon & screenshot metadata in Fastlane directory.
Please update new screenshots for Playstore & F-Droid. Playstore screenshots looks too old.

@linsui
Copy link

linsui commented Sep 19, 2022

The fdroidserver can't extract xml icon from apk. You can add it to fastlane.

I submitted the claim for the bounty.

@IzzySoft
Copy link

IzzySoft commented Oct 2, 2022

@VishalNehra now that the app is back at F-Droid.org: do you want me to remove it from my repo, or shall I keep it? See here for some background.

@VishnuSanal VishnuSanal reopened this Oct 2, 2022
@VishalNehra
Copy link
Member

@IzzySoft Please keep it in your repo. We'll continue to attach apks with releases on github. Thanks 🙏

@VishalNehra
Copy link
Member

@IzzySoft also to point out that builds that we're attaching on GitHub releases doesn't use non free dependencies any more. They're the same flavour as fdroid builds. So I request you to remove from izzy repo page warnings saying we're using non free dependencies or google services.

@IzzySoft
Copy link

IzzySoft commented Oct 6, 2022

Thanks for the reminder! Those two AFs indeed need manual check (most AFs are reported to me when gone). So I've cross-checked: Indeed I see no hint on NonFreeNet anymore, so I removed that. But I still see the JUnrar library listed which is NonFreeDep, hence I cannot remove that.

@IzzySoft
Copy link

IzzySoft commented Oct 6, 2022

PS: Should you remove that one day, please drop me a note so I can remove NonFreeDep as well. I wonder how that's dealt with in the F-Droid build – but that's a different question.

@linsui
Copy link

linsui commented Oct 6, 2022

If it's built with the fdroid flavor the junrar classes are stubs. See https://github.com/TeamAmaze/AmazeFileManager/tree/release/4.0/app/src/fdroid/java/com

@IzzySoft
Copy link

IzzySoft commented Oct 6, 2022

If it's built with the fdroid flavor

Ah, stubs – OK.

They're the same flavour as fdroid builds.

Well, Watson, combine… white-listing it then, thanks! And removing NonFreeDep accordingly (done, both, effective with the next sync today around 6 pm UTC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Issue-Severe (high) Showstopper issues that require immediate attention
Projects
None yet
Development

No branches or pull requests