New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amaze File Manager disabled on Fdroid #1684
Comments
This. Why is the F-Droid version so behind in updates? F-Droid version: 3.3.2 Play Store version: 3.3.4.79 |
Hello want to know when will be updated the F-Droid version too. |
It should be automatically updated... |
The newest F-Droid builds fail because they detect |
Perhaps |
Opened an issue with fdroid, hope they give a solution to this. |
@VishalNehra Cloudrail was indeed blacklisted since the last amaze update. https://gitlab.com/fdroid/fdroidserver/commit/b3754af137761b6cd427601a9131ea033199c4d4 Is it possible to remove cloudrail for f-droid build flavor? |
I think we need it to connect to the cloud. |
@EmmanuelMess ...I don't see an issue with a F-Droid version that can't handle clouds. |
I personally barely use cloud storage at all, none of which through Amaze, so I don't think I'd care too much if the functionality was gone from the F-Droid build. :) Alternatively, we could try and find a free replacement lib with the same or similar functionality. I'm sure there's at least something out there. |
Maybe we should create our own fork, instead of adding more differences between the Play and FDroid versions. Edit: Where is the cloudrail source? |
Nice try, from what I see it wasn't a FOSS thing so no joy. Yes, F-Droid trusted that maven repo to include only FOSS libs but that's was not an actual requirement. |
Not sure if it's related, but fdroid is warning about the source code not being available:
|
@andersonvom yes, related, there's no source that F-Droid can build from only FOSS components (this source and its dependencies) |
Update: last release on FDroid is now 3.1.2 RC1 (2yrs old, and there were 4 release candidates for that version). |
Switched to https://github.com/zhanghai/MaterialFiles |
I must say I second this. AntennaPod (which I'm active for) also had disabled one feature as a library was not FOSS. I'd rather have Amaze in the default F-Droid repository without cloud support than not have Amaze at all (I don't care for cloud support as I don't use it).
Is an option indeed, but it might not be great for discoverability for potential new users. |
To which cloud? Cloud support per se does not have to mean you have to get proprietary, as there are open source cloud implementations, Own Cloud for instance. If this library is just used to access one specific, proprietary cloud, could this feature be separated into a plug-in that than will get "blacklisted" on F-Droid, but still available on the Play Store? I guess the entire cloud software accessed here is not avaible on F-Droid, so it would do no harm to separate its access into a plugin... If it is just to have a cloud option for Amaze users, then I guess Own Cloud might be sufficient... Also, I just followed the thread about WHY Amaze got blacklisted, because it uses CloudRail. There I found that CloudRail is also discontinued! I would say that for security reasons Amaze should NOT rely on cloud code that does not get security updates. That could become a security threat in the future. And if the proprietary cloud that should have been accessed by Amaze happens to be Dropbox, in this discussion there is mention of an open source SDK for Dropbox. https://gitlab.com/fdroid/fdroiddata/issues/1817 Update: About the CloudRail Universal API: |
Maybe I'm blind but I'm not even seeing that... On the website the last version seems to be from 2017: https://f-droid.org/packages/com.amaze.filemanager/ Hence why it also has the |
@mihawk90 Yes, we went back to the last version that was entirely FOSS, is that old? Maybe... |
Ah well, must have overlooked that above. Thanks |
Cloudrail indeed is outdated, but the APIs seem to be working fine till now. And the plugin is generating revenue for us. Creating a separate flavour for fdroid will require lots of codebase changes, basically a copy of each and every file. It's simply not worth it. |
I don't know anything about coding, but gradle flavours seemed to be the solution for a similar (free/non-free/F-drod) issue with AntennaPod: AntennaPod/AntennaPod#1959 Maybe that could be a solution for Amaze as well (?) |
Why not create an AmazeFileManager repository for fdroid? |
@keunes we've been using gradle flavours in past (G+ profile picture for nav bar feature), but in this scenario, we'll have to practically maintain identical file for almost whole source code in fdroid flavour. Would be very difficult to maintain. |
Hi, I've been reading a little bit about all this thing and i would like to know what's going to happen, i jut got tired to have the old Amaze File Manager 3.1.2 RC1 (the latest version available on F-Droid, which is almost 3 years old), and i just installed the latest version today (3.4.1) because i couldn't even install the APKs from Amaze, really limited options, etc. I read (if i remember correctly at the GitLab discussion/issue dedicated to this), that the Amaze File Manager developer team would be developing a home made implementation of the cloud library that's causing all the mess (i suppose that would be FOSS, of course), and if i could know what about the status of it. Thank you very much for your great efforts and work, i really love this fantastic app, to me (excepting for the limited to pay version cloud features), the best file manager (FOSS) for Android by far. Bests ^^. |
@TakuyaSama yes it's currently being developed. Last I heard from @EmmanuelMess Onedrive was done (except upload). You can join our Telegram channel to stay updated |
|
Thanks for sharing that @EmmanuelMess. But oof - that looks like a massive work still. The best of luck with that! |
fyi, this issue now has a bounty, @linsui |
Thanks! 😂 |
@linsui we've release 3.8 please trigger fdroid build |
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11746 Amaze will be back on F-Droid in 2-3 days. |
Live on F-Droid 🎉 |
The badge is always there. 🤣 |
Alright, we're up |
Confirmed! |
Confirmed. Thanks everyone for helping on this. |
@linsui just noticed, there's no icon for Amaze on its fdroid page is that something that'll be automatically fixed? |
No such icon & screenshot metadata in Fastlane directory. |
The fdroidserver can't extract xml icon from apk. You can add it to fastlane. I submitted the claim for the bounty. |
@VishalNehra now that the app is back at F-Droid.org: do you want me to remove it from my repo, or shall I keep it? See here for some background. |
@IzzySoft Please keep it in your repo. We'll continue to attach apks with releases on github. Thanks 🙏 |
@IzzySoft also to point out that builds that we're attaching on GitHub releases doesn't use non free dependencies any more. They're the same flavour as fdroid builds. So I request you to remove from izzy repo page warnings saying we're using non free dependencies or google services. |
Thanks for the reminder! Those two AFs indeed need manual check (most AFs are reported to me when gone). So I've cross-checked: Indeed I see no hint on |
PS: Should you remove that one day, please drop me a note so I can remove |
If it's built with the fdroid flavor the junrar classes are stubs. See https://github.com/TeamAmaze/AmazeFileManager/tree/release/4.0/app/src/fdroid/java/com |
Ah, stubs – OK.
Well, Watson, combine… white-listing it then, thanks! And removing |
Currently Amaze is disabled on fdroid for the reason that it's using a few proprietary libraries. This issue is focused at providing an alternative / removing those libraries so that fdroid servers can build Amaze File Manager
This now has a bounty, here.
Please claim after a PR fixing this issue is accepted.
Remember that you can also back the issue adding to the bounty!
The text was updated successfully, but these errors were encountered: