Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg2cookiecutter.py broken after pull request changes #11

Closed
halfluck opened this issue Mar 22, 2019 · 4 comments
Closed

svg2cookiecutter.py broken after pull request changes #11

halfluck opened this issue Mar 22, 2019 · 4 comments

Comments

@halfluck
Copy link

I'm unable to run svg2cookiecutter.py after the latest pull request, I get this error

Traceback (most recent call last):
File "svg2cookiecutter.py", line 223, in
print(svgToCookieCutter(sys.argv[1]))
File "svg2cookiecutter.py", line 171, in svgToCookieCutter
line = Connector('connector'+pathName, points, fill)
File "svg2cookiecutter.py", line 140, in init
super().init(pathName, points, fill, False, None) # no stroke for connectors, thus no use of self.height and self.width
TypeError: super() takes at least 1 argument (0 given)

@arpruss
Copy link
Owner

arpruss commented Mar 22, 2019

python 2.x compatibility issue. Fixed.

@arpruss arpruss closed this as completed Mar 22, 2019
@halfluck
Copy link
Author

Working! The new features are AMAZING, so impressed right now.
Do you know if the inside walls has been improved to work?

@arpruss
Copy link
Owner

arpruss commented Mar 23, 2019

What was the problem with inside walls?

@halfluck
Copy link
Author

What was the problem with inside walls?

'holes' in feature elements within the perimeter of the cookie shape doesn't work with polygon fill
So for example the 'O' and the 'E' in one below

1

3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants