Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage support #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add coverage support #31

wants to merge 1 commit into from

Conversation

kuraga
Copy link
Contributor

@kuraga kuraga commented May 4, 2015

No description provided.

@kuraga
Copy link
Contributor Author

kuraga commented May 4, 2015

@arqex

  1. You can also add Coveralls support. I can't because registration needed.

  2. try npm run cober. You'll see:

-----------------|-----------|-----------|-----------|-----------|
File             |   % Stmts |% Branches |   % Funcs |   % Lines |
-----------------|-----------|-----------|-----------|-----------|
   freezer/      |       100 |       100 |       100 |       100 |
      freezer.js |       100 |       100 |       100 |       100 |
   freezer/src/  |        88 |     83.33 |     89.47 |      88.1 |
      emitter.js |     55.17 |      37.5 |        50 |     55.17 |
      freezer.js |       100 |      87.5 |      87.5 |       100 |
      frozen.js  |     91.03 |     90.59 |     96.97 |     90.99 |
      mixins.js  |      93.1 |     84.38 |       100 |      93.1 |
      utils.js   |     78.72 |        55 |     73.33 |     79.55 |
-----------------|-----------|-----------|-----------|-----------|
All files        |     88.06 |     83.33 |     89.47 |     88.16 |
-----------------|-----------|-----------|-----------|-----------|

So, we have some coverage problems.

@arqex
Copy link
Owner

arqex commented May 5, 2015

This is really interesting, I need some time to have a deeper look at it. The rest of badges, I don't see a benefit on having them.

Thanks for your suggestions @kuraga

@kuraga
Copy link
Contributor Author

kuraga commented May 5, 2015

Coveralls is not for a badge but for a message about coverage (example). But I agree with you - it's not very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants