Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call correct log method in DateTime component to prevent crash on invalid input #803

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

niklasnatter
Copy link
Contributor

Description

This PR adjusts the code of the DateTime component to call the correct log method. At the moment, this code crashes the component if the value prop of the DateTime component does not match the expected format. See #801

Motivation and Context

The log method was moved outside the class in d445003#diff-cae892f0886b91915576f17fd54c818f7ef44b721a3885d4a742039f1c8cad03L557-R611
Unfortunately, the call this method inside of setViewDate was not adjusted. This causes the error described above.

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

@arqex
Copy link
Owner

arqex commented Sep 6, 2021

Thanks @nnatter. It was a small refactor that was being made (and not finished), and somehow it got in to the master branch when merging the changes for the last version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants