Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arqma v0.5 Release Candidate #155

Merged
merged 158 commits into from Aug 13, 2019
Merged

Arqma v0.5 Release Candidate #155

merged 158 commits into from Aug 13, 2019

Conversation

malbit
Copy link
Member

@malbit malbit commented Jul 24, 2019

It will require some tests to be done at Stagenet

MAINNET fork heights yet has not been set. Will be set after succesfully tests with pool codebase and and transfers made without any issues.

PR includes:

  • RCTTypeBulletproof implementation,
  • PER_BYTE_FEE from Hard-Fork v13,
  • from Hard-Fork v14 which will be 720 blocks after v13 old-style ringCT transactions are forbidden,
  • increased block_median_weight_limit up to max 2048kB,
  • minimum block_weight increased up to 1024kB,
  • increased transaction_weight_limit up to 48kB,
  • rapid_sync from scratch in less than 5 minutes to fully syncd,
  • PER_BLOCK_CHECKPOINTS are ON and precompiled at codebase up to 215000 blockheight (will change for sure),
  • RPC_PAY System (will be updated),
  • Multi-Output Padded Bulletproofs,
  • public_nodes implementation,
  • static Ring_Size increased to 11 (mixin = 10),
  • tx_sanity checks
  • optimization for picking most capable outputs for transfer,
  • Arqma cryptonote_config.h simplified and will be simplified more in a future,
  • If anything more will be added it will be stated.

malbit and others added 30 commits June 11, 2019 07:01
@malbit
bulletproofs: multi-output bulletproofs
7199752
@malbit
lock_guard is required
9870b96 
Forgot to include
@malbit
bulletproofs: misc optimizations
0ee0f99 
Use double mults where possible, avoid conversions, simplify
@malbit
ringct: add bos coster multiexp
9336c04
@malbit
add Straus multiexp
cf1b4e2
@malbit
bulletproofs: add multi output bulletproofs to rct
b270039
@malbit
multiexp: bos coster now works for just one point
549a179
@malbit
make straus cached mode thread safe
7f61599
@malbit
bulletproofs: add aggregated verification
7f8dea3
@malbit
multiexp: some speedups
70f2f39
@malbit
Bulletproof aggregated verification
32aa747
@malbit
Add a define for the max number of bulletproof multi-outputs
b2e5fab
@malbit
precalc the ge_p3 representation of H
1ee787f
@malbit
multiexp: cut down on memory allocations
dd05df2
@malbit
Pippenger multiexp
0cc4b5c 
Based on sarang's python code
@malbit
Add Pippenger cache and limit Straus cache size
6469c4f
@malbit
bulletproofs: speed up a few multiplies using existing Hi cache
d26edfa
@malbit
bulletproofs: reject points not in the main subgroup
e639cc6
@malbit
bulletproofs: a few fixes from the Kudelski review
c1caba0 
- fix integer overflow in n_bulletproof_amounts
- check input scalars are in range
- remove use of environment variable to tweak straus performance
- do not use implementation defined signed shift for signum
@malbit
v13: per byte fee, pad bulletproofs
d8863d6
@malbit
ringct: prevent a potential very large allocation + rctTypes: fix inc…
aea6666 
…orrect serialization

Reported by QuarksLab.
@malbit
ringct: error out when hashToPoint* returns the point at infinity
db9ffcd
@malbit
bulletproofs: reject x, y, z, or w[i] being zero
e7951a6 
Also try again when we're generate a proof with those characteristics

Reported by QuarksLab.
@malbit
Check inputs to addKeys are in range
ed89dbf 
Reported by QuarksLab.
@malbit
multiexp: fix wrong Bos-Coster result for 1 non trivial input
c417d8c 
Reported by QuarksLab.
@malbit
cryptonote_basic: check output type before using it
ab9f6a5 
Reported by QuarksLab.
@malbit
multiexp: fix maxscalar off by one
6f1c22b
@malbit
more comprehensive test for ge_p3 comparison to identity/point at inf…
ef44afc 
…inity
@malbit
bulletproofs: match aggregated verification to sarang's latest prototype
5a40700
bulletproofs: scale points by 8 to ensure subgroup validity
c7d90ef
@malbit malbit merged commit ded18de into arqma:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArqTras ArqTras ArqTras approved these changes

@Ogy Ogy Awaiting requested review from Ogy

@muscleman muscleman Awaiting requested review from muscleman

@kuczys kuczys Awaiting requested review from kuczys

@SmajeNz0 SmajeNz0 Awaiting requested review from SmajeNz0

Assignees
No one assigned
Labels
enhancement New feature or request Need to be Tested Tests Required before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malbit @ArqTras