Fix deployment strategy #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bouskaJ
force-pushed
the
fix_deployment_strategy
branch
from
7f9ac8d
to
8b99333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request fixes shortcomings which are described in #54 (comment) and can be easily reproduced by running ComplexDeploymentTestCase
Description
a663171#diff-94377c156735b39dfa4ac607234cb87c splits arquillian deployment into 3 separate bundles:
This split totally destroy backward compatibility and breaks all tests which are dependent on some class from deployment archive. Moreover Deployments which requires import packages such as
org.junitcan't be deployed.What was fixed: