Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Jakarta related dependent modules should be broken out #516

Closed
starksm64 opened this issue Nov 13, 2023 · 5 comments
Closed

The Jakarta related dependent modules should be broken out #516

starksm64 opened this issue Nov 13, 2023 · 5 comments
Assignees

Comments

@starksm64
Copy link
Member

Issue Overview

With the revival of the Jakarta EE specifications starting to produce new content, an issue with keeping the Arquillian modules related to the Jakarta EE APIs is that The EE APIs are updating the requirement Java SE used for compliation. EE 10 had a baseline of Java SE 11 and EE 11 will have a baseline of Java SE 21.

The problem this causes in seen in the current CI build of the #514 PR. Updating the Jakarta Rest api version to 3.1.0 has added a requirement for Java SE 11 and the Java SE 8 based tests are now failing.

What I would propose is that:

  1. Create a new arquillian-jakarta repository
  2. The exisitng arquillian-core repo submodules that depend on Jakarta EE apis be moved into the arquillian-jakarta repo
  3. A new 1.8.0.Final release of arquillian-core is made without the arquillian-jakarta content
  4. a 1.8.0.Final release of the arquillian-jakarta content is made
@jamezp
Copy link
Collaborator

jamezp commented Nov 14, 2023

This sounds like a good plan to me. I think it makes sense to have the arquillian-jakarta repository and do a clean 1.8 break. We could even start requiring Java 11 for arquillian-core, but that's not critical at all.

@starksm64
Copy link
Member Author

We could and probably should leave the legacy Java EE based modules in the core repo since they would probably never be touched again anyway.

@bartoszmajsak
Copy link
Member

FWIW I created a repo for this https://github.com/arquillian/arquillian-jakarta

starksm64 added a commit to starksm64/arquillian-core that referenced this issue Nov 16, 2023
Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64 starksm64 self-assigned this Nov 16, 2023
starksm64 added a commit that referenced this issue Nov 17, 2023
Signed-off-by: Scott M Stark <starksm64@gmail.com>
starksm64 added a commit to arquillian/arquillian-jakarta that referenced this issue Nov 17, 2023
Add distributionManagement section
Add relativePath to parent pom
Move jakarta.* package based protocols and testenrichers to the
arquillian-jakarta repo
Part 2 of arquillian/arquillian-core#516

Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64
Copy link
Member Author

This has been done. The first arquillian-core release to pick up this change will be the 1.8.0.Final release

@jamezp
Copy link
Collaborator

jamezp commented Nov 17, 2023

If needed, next week I can test local builds of the SNAPSHOT's in wildfly-arquillian. I assume they work fine, but just to test it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants