Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): uses repo id into as property #441

Merged
merged 4 commits into from Nov 21, 2022

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 18, 2022

Short description of what this resolves:

Deploy repository IDs are not overridable in the BOM

Changes proposed in this pull request:

Using the already-existing variable / property for repository ID

@lprimak
Copy link
Contributor Author

lprimak commented Nov 18, 2022

another one @bartoszmajsak
pretty trivial

@bartoszmajsak
Copy link
Member

@lprimak it's been a while since I betrayed Maven to Makefiles so I am wondering from where is the value of jboss.releases.repo.id coming? We don't have a parent set here so I fail to see it set. In other places, we inherit from jboss-parent but not here.

@lprimak
Copy link
Contributor Author

lprimak commented Nov 19, 2022

@bartoszmajsak ah! you are correct! I totally missed that there is no parent in BOM
I will fix that in short order, thanks!

@lprimak
Copy link
Contributor Author

lprimak commented Nov 19, 2022

fixed!

@bartoszmajsak bartoszmajsak changed the title change repo id into a property fix(build): uses repo id into as property Nov 21, 2022
@bartoszmajsak bartoszmajsak merged commit d75d3cf into arquillian:master Nov 21, 2022
@bartoszmajsak bartoszmajsak deleted the fix-bom-repos branch November 21, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants