WFLY-2641 - fix NPE that could occur intermittently #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -287,7 +287,7 @@ public Object getInstance() | |||
| return test; | |||
| } | |||
| }); | |||
| if(result.getThrowable() != null) | |||
| if (result != null && result.getThrowable() != null) | |||
There was a problem hiding this comment.
This is just masking some type of error.. Can't add this and pretend the test passed..
There was a problem hiding this comment.
Tests still fails and we seem to get proper failure back
|
Have you tried to downgrade to junit 4.10? |
|
We tried downgrading to 4.10 but we have too much testsuite framework code written that uses 4.11 features. |
|
Can we get this merged & release with this fix in it? |
bstansberry
referenced
this pull request
in wildfly/wildfly
Jan 24, 2014
|
Not the correct fix. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix WildFly testsuite is much more stable.
I know this fix is not proper solution, but until we have one, lets keep this.
I could track down that root cause has to do with Expected Exception handling but could not narrow it down where exactly should it be fixed.
It could as well be related to bug/change in junit 4.11 for more see junit-team/junit4#711