Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Fabric8 Kubernetes Client to 4.10.2 #1192

Closed

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Aug 24, 2020

This is to support latest Kubernetes and OpenShift releases,
where the old Fabric8 Kubernetes Client doesn't work correctly.

This commit also updates the Snowdrop Istio Java API to
a version that also uses Fabric8 Kubernetes Client 4.10.2.
There's currently no Snowdrop Istio Java API release that
uses Fabric8 Kubernetes Client 4.10.3, which is why this
commit only updates to 4.10.2.

Fixes #1118

This is to support latest Kubernetes and OpenShift releases,
where the old Fabric8 Kubernetes Client doesn't work correctly.

This commit also updates the Snowdrop Istio Java API to
a version that also uses Fabric8 Kubernetes Client 4.10.2.
There's currently no Snowdrop Istio Java API release that
uses Fabric8 Kubernetes Client 4.10.3, which is why this
commit only updates to 4.10.2.
@Ladicek
Copy link
Contributor Author

Ladicek commented Aug 24, 2020

I'd like to highlight that there's a TON of failing tests (at least for me). I started fixing them, but it takes a lot of time, since they are hard to debug. So I'm submitting just the commit that updates Fabric8 Kubernetes client, because I know of at least 2 teams that would need this. (Also if Arquillian Cube is essentially dead, we would also love to know :-) )

@bartoszmajsak
Copy link
Member

bartoszmajsak commented Aug 25, 2020

I'd like to highlight that there's a TON of failing tests (at least for me).

Are you saying that this PR breaks tests? Which tests are you referring to - CI ran against Openshift 3.x?

So I'm submitting just the commit that updates Fabric8 Kubernetes client

Can't really accept PR which breaks things. We have to figure out what's the actual issue here and decide on the way we resolve it. What are the fixes you managed to apply to make some tests green so far?

Also if Arquillian Cube is essentially dead, we would also love to know :-)

It's not actively developed - there are no new features planned, but it's maintained.

@Ladicek
Copy link
Contributor Author

Ladicek commented Aug 25, 2020

I'm not saying this PR breaks tests. I'm saying there's like 10 tests failing if I run mvn clean install locally, while connected to some arbitrary OpenShift cluster. I don't know if there are known intermittently-failing tests or if that's just my environment, so I wanted to be explicit about that. And I wanted to get this out, because I know of people who need it.

I'll try to find some time to investigate, but as I said, it isn't exactly easy :-)

@bartoszmajsak
Copy link
Member

I'm not saying this PR breaks tests. I'm saying there's like 10 tests failing if I run mvn clean install locally, while connected to some arbitrary OpenShift cluster.

Ok, that info helps :) Let me have a look at it on my side too.

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 19, 2021

Closing this as I've migrated off of Arquillian Cube.

@Ladicek Ladicek closed this Feb 19, 2021
@Ladicek Ladicek deleted the update-fabric8-kubernetes-client branch February 19, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to kubernetes-client 4.2.2.
2 participants