[ARQ-653] Reworked configuration sharing between client and container side. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… side. It's using yaml serialization/deserialization to pass only relevant bits of the persistence extension configuration.
|
|
||
| // when | ||
| fire(new BeforeSuite()); | ||
| PersistenceConfiguration persistenceConfiguration = getManager().getContext(ApplicationContext.class) |
There was a problem hiding this comment.
@Inject Instance should work as well.. :)
|
Thanks for the review Aslak. I will clean it up and push upstream soon. |
|
Changed as suggested and pushed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's using yaml serialization/deserialization to pass only relevant bits of the persistence extension configuration.
I was having troubles trying to use the same approach on the container side as it's used in ConfigurationRegistrar (Shrinkwrap). Details here: https://gist.github.com/1396309
Pros: compact representation with only relevant stuff for persistence extension.
Cons: different approach, additional dependency for the extension (if you don't want to use YAML for datasets).