Initial support for SQL Populator #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
requested changes
Mar 28, 2017
| @@ -70,7 +80,14 @@ public RestPopulatorConfigurator withVariables(String key, String value, String. | |||
| @Override | |||
| public void execute() { | |||
| if (urlOverride) { | |||
| this.populatorService.execute(this.host, this.bindPort, Collections.unmodifiableList(this.datasets), Collections.unmodifiableMap(variables)); | |||
| // TODO should runners manage uri internally? Yes let's do it in next alpha since it is an internal change | |||
There was a problem hiding this comment.
Maybe convert it to the task?
| import java.util.*; | ||
|
|
||
| /** | ||
| * Implementation of NoSql DSL configurator. |
There was a problem hiding this comment.
Not really useful comment, but also wrong :) (copy-paste?)
|
|
||
| @Override | ||
| public void execute() { | ||
| // TODO Improve this so connect and disconnect only happens once. |
| import org.jboss.arquillian.populator.core.PopulatorEnricher; | ||
|
|
||
| /** | ||
| * Implementation of Populator enricher for Sql support. |
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Extends the populator service for NoSql services. Each NoSql database should implement this interface, for example one for MongoDb, another one for Redis, ... |
| @Populator | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ElementType.FIELD}) | ||
| public @interface Sql { |
There was a problem hiding this comment.
Maybe RDBMS instead? SQL is a language
| try { | ||
| final JdbcDatabaseTester jdbcDatabaseTester = new JdbcDatabaseTester(driver.getName(), jdbc.toString(), username, password); | ||
|
|
||
| // TODO add custom option to get the schema to use |
| .map(resource -> { | ||
| String type = resource.substring(resource.lastIndexOf('.')); | ||
| switch (type) { | ||
| case "xml": { |
There was a problem hiding this comment.
Later on probably strategy instead of switch + reusing what we have from Core (JSON, YAML)
bartoszmajsak
pushed a commit
that referenced
this pull request
Mar 28, 2017
|
Upstream @33f989a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Initial support for SQL Populator
Changes proposed in this pull request: