Adds Vault support. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
approved these changes
Apr 11, 2017
| private Vault vault; | ||
|
|
||
| public Secrets(String host, int port, String token) throws VaultException { | ||
| this.vaultConfig = new VaultConfig(String.format("http://%s:%s", host, port), token); |
There was a problem hiding this comment.
Second placeholder for in the format should be %d I believe.
There was a problem hiding this comment.
It is not necessary, you can do %d or %s and calls the toString method.
There was a problem hiding this comment.
I know, but just for correctness of what you really expect.
|
|
||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
I think we can save on empty lines here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.