Adds Infinispan support #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
requested changes
May 15, 2017
| </dependency> | ||
| <dependency> | ||
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> |
There was a problem hiding this comment.
I know we have both assertj and junit defined as test scope in the parent pom's dependencyManagement. The problem here is however that this information is not easily available and thus making it confusing here. All other dependencies have explicit test scope specified but these not - then we can start wondering why is it so, as default scope when not specified is not test. Can we agree on a convention here?
| try { | ||
| defaultInfinispanInsertionStrategy.insert(() -> infinispanBasicCache, dataset); | ||
| } catch (Throwable e) { | ||
| throw new IllegalStateException(e); |
There was a problem hiding this comment.
Maybe we can add a short message under what circumstances this error happened? Otherwise, it might not be so obvious from the stack trace.
bartoszmajsak
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Adds Infinispan support
Changes proposed in this pull request: