Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARQ-1104] - Spring deployer should include all spring artifacts. #16

Closed
wants to merge 3 commits into from

Conversation

jmnarloch
Copy link
Member

For review and pull upstream.

@jmnarloch
Copy link
Member Author

@aslakknutsen Got some stuff to merge, when you find time.

@jmnarloch
Copy link
Member Author

@aslakknutsen Hello? :)

@aslakknutsen
Copy link
Member

Your packaging up all of spring every time here right?

It seems to double the runtime of the int test suites. And i'm not sure a user would always want everything. Maybe add them based on artifact/packages found on application classpath as default?

@jmnarloch
Copy link
Member Author

@mbogoevici What do you think? Should we include all artifacts? Or do some classpath scanning?

@mbogoevici
Copy link

I think we should allow three different configurable modes:

  • POM-based (dependencies available in the BOM should we packaged) or CP-based - default
  • no-deps (no Spring dependencies included;
  • all-deps (all Spring deps included).

Of the three, the last one is the hardest to build a case for (as the dependency set is by design different from the one used in the actual application), but it can have its uses.

@jmnarloch
Copy link
Member Author

Change has been merged and pushed upstream: c4b148d.

@jmnarloch jmnarloch closed this May 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants