Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorized strategy properties are not being recognized when using a configuration file #318

Closed
spriadka opened this issue Feb 15, 2018 · 1 comment · Fixed by #319
Closed

Comments

@spriadka
Copy link
Contributor

Issue Overview

Properties from configuration file are not getting mapped into the categorized strategy configuration.

Expected Behaviour

When running smart testing with the categorized strategy and a configuration file, smart testing should configure the categorized strategy from configuration file correctly.

Current Behaviour

When running smart testing with categorized strategy and a configuration file, properties set in that file are not being recognized by the execution itself. According to the report.xml smart testing sees only, that the categorized strategy has been applied, but all the properties are ignored.

 <executionConfiguration>
        <usageMode>selecting</usageMode>
        <strategies>
            <strategy>categorized</strategy>
        </strategies>
        <properties>
            <property name="smart.testing" value="categorized"/>
        </properties>
    </executionConfiguration

Running smart testing with properties set as command line arguments are recognized properly.

Steps To Reproduce
  1. Clone this repository https://github.com/spriadka/testsuite/tree/7.1.x-categories
  2. Set up the machine according to the README
  3. Create smart-testing.yml following:
strategies: categorized
debug: true
strategiesConfiguration:
  categorized:
    categories: Elytron
  1. Execute following command
mvn -Pbasic,standalone -Djboss.dist=<your_jboss_dist> -Darq.extension.webdriver.firefox_binary=<your_ff_binary_path> -Dtest="ElytronPolicyTestCase*" test
  1. See the basic/target/.smart-testing/report.xml
@MatousJobanek
Copy link
Contributor

Hi @spriadka
thank you for reporting this issue. This is caused by improper lazy loading of the configuration files.
This should fix the issue: #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants