fix(not reusing fork) ordering/selecting of test classes is moved to getSuites method #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getSuites method, then when surefire pass the test set to the invoke method it takes that one. In the case of not reusing forks, surefire calls getSuites and calls the method invoke on new provider instance for each item in the getSuites response
lordofthejars
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of not reusing forks:
<reuseForks>false</reuseForks>surefire calls
getSuitesand calls the method invoke on new provider instance for each item in the getSuites response. This means that the test set retrieved fromgetSuitesis already ordered/selected.When surefire pass the test set to the invoke method it takes that one. Again, it is simulating the way that it is done in original surefire providers