Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where base path was ignored #30

Merged
merged 1 commit into from
May 18, 2015

Conversation

claptimes5
Copy link
Contributor

Fixes #9

  • Fixes issue where custom base path of /wiki would be ignored by omniauth
  • Uses fix suggested by @aldanor

arr2036 added a commit that referenced this pull request May 18, 2015
Fix issue where base path was ignored
@arr2036 arr2036 merged commit b77cf5f into arr2036:master May 18, 2015
@claptimes5 claptimes5 deleted the base-path branch May 18, 2015 12:40
@njman
Copy link

njman commented Jun 4, 2015

There was an issue when integrating omniauth-ldap, please check its issue.

Not sure whether the root cause is on omnigollum or not, Just copy that as following:

I want wiki sub-directory, e.g. http://localhost:4567/wiki/Home, /wiki/ is the sub-directory.

Gollum support --base-path option in Rack way, please check the wiki tips.
The omnigollum support it by the pull.
However, omniauth-ldap has Sign In problem, i.e. always return to Home page once submit.
Look around the LDAP Authentication html source:

      <body>
      <h1>LDAP Authentication</h1>
      <form method='post' action='/__omnigollum__/auth/ldap/callback' noValidate='noValidate'>

<label for='username'>Login:</label>
<input type='text' id='username' name='username'/>
<label for='password'>Password:</label>
<input type='password' id='password' name='password'/>
<button type='submit'>Sign In</button>      </form>
      </body>

I doubted on this line:

action='/__omnigollum__/auth/ldap/callback'

should write:

action='/wiki/__omnigollum__/auth/ldap/callback'

Not sure. How to resolve this problem, thanks.

@aldanor
Copy link
Contributor

aldanor commented Jun 4, 2015

@njman I've answered in omniauth/omniauth-ldap#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omnigollum and base_path
4 participants