Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D bindings for ArrayFire using C APIs. #1

Merged
merged 16 commits into from Apr 20, 2017
Merged

Conversation

prasunanand
Copy link
Member

@prasunanand prasunanand commented Apr 8, 2017

  • Created D bindings for ArrayFire.
  • D doesn't have complete support binding through C++.
  • Swig was not an alternative as it has no proper support especially for arrays.
  • Works perfectly with LDC for linear algebra, which I am concerned with.

Please review :=) .

I will add the examples in next PR.

Copy link
Member

@pavanky pavanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all the comments if possible ?

dub.json Outdated
"authors": [
"Prasun Anand"
],
"libs": ["afcuda", "cusolver", "cudart", "cufft", "cublas"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this line is wrong. Removing it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanky , Don't we need the documentation for arraytfire-d? I had left the comments there for documentation.

@prasunanand
Copy link
Member Author

@pavanky : I left the comments for docs. What do you suggest?

@pavanky
Copy link
Member

pavanky commented Apr 20, 2017

@prasunanand This is not really a "D" binding. This is a good first step, it exports the C API so it can be used from D.

We still need to implement a D array class similar to what we have in C++ and wrap all the functions to be more D like.

@prasunanand
Copy link
Member Author

prasunanand commented Apr 20, 2017

Cool. I will remove these comments.

I would look into implementing a D array class similar to C++ making it more D like .
Maybe we can have it in the next PR :) .

@pavanky
Copy link
Member

pavanky commented Apr 20, 2017

Sure, remove the comments when you are adding the class. I am merging this in for now.

@pavanky pavanky merged commit 1500692 into arrayfire:master Apr 20, 2017
@prasunanand
Copy link
Member Author

Thank You :)
I had started working on removing the comments btw for this merge itself.

@prasunanand prasunanand deleted the devel branch April 20, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants