Remove CUDA 6.5 Support #1687
Merged
Remove CUDA 6.5 Support #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove boost inline for older CUDA versions
|
@shehzan10 Is there any reason you refrained from enabling C++11 support ? |
|
I wanted that to be done when C++11 features start getting used. That is, the boost stuff is replaced by STL. |
pavanky
reviewed
Dec 23, 2016
| #if CUDA_VERSION < 7000 | ||
| #error "ArrayFire CUDA requires CUDA Toolkit Version 7.0 or newer." | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Any reason you want to have this here instead of cmake?
In CMake it is as simple as requesting a minimum version in FIND_PACKAGE(CUDA, 7.0) or something similar.
There was a problem hiding this comment.
Yeah, we could do that.
|
@shehzan10 merge ? |
|
Let me run the PR builds. Somehow forgot about it. PS. OSX CUDA Might fail on tests - But thats a system issue. build arrayfire linux ci |
|
I think it can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with removing CUDA 6.5 support and asserting a minimum CUDA version of 7.0.
It does NOT enable features such as C++11 etc that are associated with using CUDA 7 as minimum version.