Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the indexing tutorial #2558

Merged
merged 4 commits into from Jul 9, 2019
Merged

Improve the indexing tutorial #2558

merged 4 commits into from Jul 9, 2019

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Jun 28, 2019 •
edited

Adding more details to the indexing tutorials.

image

9prady9
9prady9 reviewed Jul 3, 2019
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. I found couple of typos, may be there are more. I will give it another pass later again.

docs/pages/indexing.md Outdated Show resolved Hide resolved
ShadyBoukhary
ShadyBoukhary reviewed Jul 5, 2019
View reviewed changes
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Show resolved Hide resolved
@umar456
Copy link
Member Author

umar456 commented Jul 9, 2019

Addressed Feedback:

image

9prady9
9prady9 requested changes Jul 9, 2019
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. There are few grammatical mistakes and typos.

docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Outdated Show resolved Hide resolved
docs/pages/indexing.md Show resolved Hide resolved
@umar456 umar456 merged commit acfac26 into arrayfire:master Jul 9, 2019
@9prady9 9prady9 deleted the indexing_docs branch July 10, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadyBoukhary ShadyBoukhary ShadyBoukhary left review comments

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umar456 @9prady9 @ShadyBoukhary