Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zero padding in convolve2NN #2820

Merged
merged 2 commits into from Apr 8, 2020
Merged

Conversation

syurkevi
Copy link
Contributor

@syurkevi syurkevi commented Apr 2, 2020

zero padding issue due to "empty" dim4 in c++ api.
adds fixes and simple tests addressing #2817

Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please fix the formatting.

@9prady9 9prady9 merged commit decde4e into arrayfire:master Apr 8, 2020
@9prady9 9prady9 deleted the issue2817 branch April 8, 2020 05:07
@9prady9 9prady9 mentioned this pull request Apr 8, 2020
@9prady9 9prady9 added this to the 3.7.2 milestone Apr 8, 2020
@umar456 umar456 mentioned this pull request Jun 27, 2020
2 tasks
umar456 pushed a commit to umar456/arrayfire that referenced this pull request Jul 3, 2020
* add tests for zero padding

* fix clang formatting
9prady9 pushed a commit that referenced this pull request Jul 5, 2020
* add tests for zero padding

* fix clang formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants