Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty array handling in lu, rank, and qr. Other minor refactoring #2838

Merged
merged 4 commits into from Apr 13, 2020
Merged

Fix empty array handling in lu, rank, and qr. Other minor refactoring #2838

merged 4 commits into from Apr 13, 2020

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Apr 11, 2020

  • some linear algebra functions could have leaked memory in case the input was null. This PR addresses that potential leak and handles the empty or null array case.
  • Minor refactor in median
  • Minor refactor in DefaultMemoryManager. Just changed names of the variables.

@umar456 umar456 added this to the 3.7.2 milestone Apr 11, 2020
9prady9
9prady9 requested changes Apr 11, 2020
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the formatting problem in the following files:
test/memory.cpp
test/median.cpp

src/api/c/lu.cpp Show resolved Hide resolved
test/lu_dense.cpp Outdated Show resolved Hide resolved
src/backend/common/DefaultMemoryManager.cpp Show resolved Hide resolved
src/backend/common/DefaultMemoryManager.cpp Show resolved Hide resolved
src/backend/common/DefaultMemoryManager.cpp Outdated Show resolved Hide resolved
src/backend/common/DefaultMemoryManager.cpp Outdated Show resolved Hide resolved
src/backend/common/DefaultMemoryManager.cpp Outdated Show resolved Hide resolved
src/api/c/median.cpp Show resolved Hide resolved
test/median.cpp Show resolved Hide resolved
@umar456 umar456 requested a review from 9prady9 April 12, 2020 16:32
9prady9
9prady9 requested changes Apr 13, 2020
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memory leaks in all new tests for lu_dense.cpp, qr_dense.cpp and rank_dense.cpp. I believe that is why the ASAN tests failed.

Also, the formatting is still off in test/memory.cpp file.

@umar456 umar456 requested a review from 9prady9 April 13, 2020 10:59
@umar456
Copy link
Member Author

umar456 commented Apr 13, 2020

Addressed all feedback

@umar456 umar456 merged commit 2e098d4 into arrayfire:master Apr 13, 2020
@9prady9 9prady9 deleted the empty_fix branch April 13, 2020 13:29
@umar456 umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@umar456 @9prady9