New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for versioned loading of libs at runtime; Fix cudnn cmake install command #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving sample output of versioned loading for reference.
|
9prady9
force-pushed
the
fix_cmake_install_cudnn_win
branch
from
June 30, 2020 08:20
9a0e608
to
1f5b14f
Compare
9prady9
changed the title
Fix cudnn cmake install command
Add support for versioned loading of libs at runtime; Fix cudnn cmake install command
Jun 30, 2020
9prady9
force-pushed
the
fix_cmake_install_cudnn_win
branch
3 times, most recently
from
July 1, 2020 03:38
c185649
to
f2dc035
Compare
umar456
previously approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments. They are not major.
pavanky
reviewed
Jul 1, 2020
pavanky
reviewed
Jul 1, 2020
9prady9
force-pushed
the
fix_cmake_install_cudnn_win
branch
from
July 2, 2020 06:01
f2dc035
to
ed1e916
Compare
umar456
previously approved these changes
Jul 2, 2020
9prady9
force-pushed
the
fix_cmake_install_cudnn_win
branch
from
July 2, 2020 17:51
ed1e916
to
85ba607
Compare
umar456
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this change, cuDNN library will be installed as
<lib prefix>cudnn<lib suffix><soname>
on unix platform.Changes to Users
None
Checklist
[ ] Tests pass[ ] Functions added to unified API[ ] Functions documented