Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where ndims was incorrectly used to calculate shape of input #3277

Merged
merged 1 commit into from Sep 12, 2022

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Jul 23, 2022

Fix the assertion to validate the input shape of the stride, padding and dilation array

Description

In C functions, the way the shapes of the input shapes are passed into functions is
using an array of dim_t values and an unsigned integer. The unsigned integer is used
to indicate how many values are in the input array. It does not indicate the number of
axis of the resulting dim4 object. This distinction caused an error with the new
convolve functions.

Changes to Users

Users will be able to pass any values to the stride_dims, padding_dims and dilation_dims
values.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

@9prady9 9prady9 merged commit 5a51205 into arrayfire:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants