Minor changes to Katib manifests (kubeflow#457)

* Adding PeriodSeconds to livenessProbe * Add tests * Adding extra kubectl output
arrikto · Oct 10, 2019 · 2964e1c · 2964e1c
1 parent 60b1248
commit 2964e1c
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 0 deletions.
diff --git a/katib/katib-controller/base/katib-manager-deployment.yaml b/katib/katib-controller/base/katib-manager-deployment.yaml
@@ -43,3 +43,5 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
diff --git a/katib/katib-crds/base/trial-crd.yaml b/katib/katib-crds/base/trial-crd.yaml
@@ -5,6 +5,9 @@ metadata:
 spec:
   additionalPrinterColumns:
   - JSONPath: .status.conditions[-1:].type
+    name: Type
+    type: string
+  - JSONPath: .status.conditions[-1:].status
     name: Status
     type: string
   - JSONPath: .metadata.creationTimestamp

diff --git a/tests/katib-controller-base_test.go b/tests/katib-controller-base_test.go
@@ -405,6 +405,8 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
 `)
 	th.writeF("/manifests/katib/katib-controller/base/katib-manager-rest-deployment.yaml", `
 apiVersion: apps/v1

diff --git a/tests/katib-controller-overlays-application_test.go b/tests/katib-controller-overlays-application_test.go
@@ -484,6 +484,8 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
 `)
 	th.writeF("/manifests/katib/katib-controller/base/katib-manager-rest-deployment.yaml", `
 apiVersion: apps/v1

diff --git a/tests/katib-controller-overlays-istio_test.go b/tests/katib-controller-overlays-istio_test.go
@@ -442,6 +442,8 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
 `)
 	th.writeF("/manifests/katib/katib-controller/base/katib-manager-rest-deployment.yaml", `
 apiVersion: apps/v1

diff --git a/tests/katib-crds-base_test.go b/tests/katib-crds-base_test.go
@@ -85,6 +85,9 @@ metadata:
 spec:
   additionalPrinterColumns:
   - JSONPath: .status.conditions[-1:].type
+    name: Type
+    type: string
+  - JSONPath: .status.conditions[-1:].status
     name: Status
     type: string
   - JSONPath: .metadata.creationTimestamp