Remove unused field from Experiment Spec (kubeflow#806)

* Remove unused field from Spec

* Remove references

pkg/apis/controller/experiments/v1alpha3/experiment_types.go

@@ -44,9 +44,6 @@ type ExperimentSpec struct {
 	// Max failed trials to mark experiment as failed.
 	MaxFailedTrialCount *int32 `json:"maxFailedTrialCount,omitempty"`
 
-	// Whether to retain historical data in DB after deletion.
-	RetainHistoricalData bool `json:"retainHistoricalData,omitempty"`
-
 	// For v1alpha3 we will keep the metrics collector implementation same as v1alpha1.
 	MetricsCollectorSpec *common.MetricsCollectorSpec `json:"metricsCollectorSpec,omitempty"`
 

pkg/apis/controller/experiments/v1alpha3/util.go

@@ -143,33 +143,3 @@ func (exp *Experiment) MarkExperimentStatusFailed(reason, message string) {
 	}
 	exp.setCondition(ExperimentFailed, v1.ConditionTrue, reason, message)
 }
-
-func (exp *Experiment) NeedUpdateFinalizers() (bool, []string) {
-	deleted := !exp.ObjectMeta.DeletionTimestamp.IsZero()
-	pendingFinalizers := exp.GetFinalizers()
-	contained := false
-	for _, elem := range pendingFinalizers {
-		if elem == cleanDataFinalizer {
-			contained = true
-			break
-		}
-	}
-
-	if !deleted && !contained {
-		if exp.Spec.RetainHistoricalData {
-			return false, []string{}
-		}
-		finalizers := append(pendingFinalizers, cleanDataFinalizer)
-		return true, finalizers
-	}
-	if deleted && contained {
-		finalizers := []string{}
-		for _, pendingFinalizer := range pendingFinalizers {
-			if pendingFinalizer != cleanDataFinalizer {
-				finalizers = append(finalizers, pendingFinalizer)
-			}
-		}
-		return true, finalizers
-	}
-	return false, []string{}
-}

pkg/controller.v1alpha3/experiment/experiment_controller_test.go

@@ -234,9 +234,8 @@ func newFakeInstance() *experimentsv1alpha3.Experiment {
 			Namespace: namespace,
 		},
 		Spec: experimentsv1alpha3.ExperimentSpec{
-			RetainHistoricalData: false,
-			ParallelTrialCount:   &parallelCount,
-			MaxTrialCount:        &parallelCount,
+			ParallelTrialCount: &parallelCount,
+			MaxTrialCount:      &parallelCount,
 			Objective: &commonapiv1alpha3.ObjectiveSpec{
 				Type:                commonapiv1alpha3.ObjectiveTypeMaximize,
 				Goal:                &goal,