Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #9

Closed
arriven opened this issue Feb 27, 2022 · 2 comments · Fixed by #3
Closed

Improve logging #9

arriven opened this issue Feb 27, 2022 · 2 comments · Fixed by #3
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arriven
Copy link
Owner

arriven commented Feb 27, 2022

Logs are formatted pretty poorly right now. Ideally we want to have an ability to write logs to different log levels (debug, info, warning, error, etc.) with better formatting.
After that we'd also need a cmdline option to set minimal logging level with everything below turning into noop to not spam users with debug logs and minimize performance impact
@arriven arriven added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 27, 2022
@arriven arriven linked a pull request Feb 27, 2022 that will close this issue
logs #3
Merged
@arriven
Copy link
Owner Author

arriven commented Feb 27, 2022

Still need to implement disabling particular log levels

@arriven arriven reopened this Feb 27, 2022
@arriven
Copy link
Owner Author

arriven commented Feb 27, 2022

Implemented in 7728c69

@arriven arriven closed this as completed Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logs
1 participant
@arriven