should check the argument

arrmac · Jul 15, 2012 · a2f9d49 · a2f9d49
1 parent 851f216
commit a2f9d49
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/class.c b/class.c
@@ -779,6 +779,7 @@ rb_mod_included_modules(VALUE mod)
 VALUE
 rb_mod_include_p(VALUE mod, SEL sel, VALUE mod2)
 {
+    Check_Type(mod2, T_MODULE);
     return rb_ary_includes(rb_mod_included_modules(mod), mod2);
 }
 

diff --git a/complex.c b/complex.c
@@ -1322,10 +1322,10 @@ static VALUE
 nucomp_marshal_load(VALUE self, SEL sel, VALUE a)
 {
     get_dat1(self);
-    VALUE ary = rb_convert_type(a, T_ARRAY, "Array", "to_ary");
-    GC_WB(&dat->real, RARRAY_AT(ary, 0));
-    GC_WB(&dat->imag, RARRAY_AT(ary, 1));
-    rb_copy_generic_ivar(self, ary);
+    Check_Type(a, T_ARRAY);
+    GC_WB(&dat->real, RARRAY_AT(a, 0));
+    GC_WB(&dat->imag, RARRAY_AT(a, 1));
+    rb_copy_generic_ivar(self, a);
     return self;
 }
 

diff --git a/rational.c b/rational.c
@@ -1583,10 +1583,11 @@ static VALUE
 nurat_marshal_load(VALUE self, SEL sel, VALUE a)
 {
     get_dat1(self);
-    VALUE ary = rb_convert_type(a, T_ARRAY, "Array", "to_ary");
-    GC_WB(&dat->num, RARRAY_AT(ary, 0));
-    GC_WB(&dat->den, RARRAY_AT(ary ,1));
-    rb_copy_generic_ivar(self, ary);
+    Check_Type(a, T_ARRAY);
+    GC_WB(&dat->num, RARRAY_AT(a, 0));
+    GC_WB(&dat->den, RARRAY_AT(a ,1));
+    rb_copy_generic_ivar(self, a);
+
     if (f_zero_p(dat->den)) {
 	rb_raise_zerodiv();
     }

diff --git a/spec/frozen/tags/macruby/core/module/include_tags.txt b/spec/frozen/tags/macruby/core/module/include_tags.txt
@@ -2,4 +2,3 @@ fails:Module#include adds all ancestor modules when a previously included module
 fails:Module#include doesn't include module if it is included in a super class
 fails:Module#include recursively includes new mixins
 fails:Module#include preserves ancestor order
-fails:Module#include? raises a TypeError when no module was given