Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerization of Project for Development #191

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Dockerization of Project for Development #191

merged 5 commits into from
Apr 8, 2024

Conversation

MateehUllah
Copy link
Contributor

@MateehUllah MateehUllah commented Mar 28, 2024 •
edited

Issue Title: Docker Compose file

  • Created Docker file along entrypoint.sh
  • Created Docker Compose file
  • Updated readme
  • Added host into settings.py
Screenshot 2024-03-28 at 7 51 57 AM

@elarroba elarroba self-assigned this Mar 29, 2024
@elarroba elarroba self-requested a review March 29, 2024 12:27
elarroba
elarroba requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@elarroba elarroba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments to the files.
Thx Miguel

entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
dev_env/settings.py Outdated Show resolved Hide resolved
@elarroba elarroba linked an issue Mar 29, 2024 that may be closed by this pull request
docker compose file #176
Closed
@elarroba elarroba added enhancement New feature or request feature request Request of new features ci/cd Continous Integration & Development labels Mar 29, 2024
@MateehUllah
Copy link
Contributor Author

@elarroba I updated the code. You can review it again.

Thanks Mateeh Ullah.

@elarroba elarroba changed the title Dockerization of Project Dockerization of Project for Development Apr 8, 2024
elarroba
elarroba approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@elarroba elarroba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@elarroba elarroba merged commit a08279c into arrobalytics:develop Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elarroba elarroba elarroba approved these changes

Assignees

@elarroba elarroba

Labels
ci/cd Continous Integration & Development enhancement New feature or request feature request Request of new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker compose file
2 participants
@MateehUllah @elarroba