Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Re-encode bindings using arrow-continuations #252

Merged
merged 12 commits into from Oct 28, 2020

Conversation

danimontoya
Copy link
Contributor

@danimontoya danimontoya commented Oct 26, 2020

The goal here is to remove all current reflection tricks used and first step to delete continuation utils by using reset / shift from arrow-continuations.
Here is a draft list of things that we need to refactor:

  • const, either, eval, validated
  • Monad bindings: MonadSyntax, MonadContinuation, MonadContinuations, MonadFilterContinuation ComonadContinuation
  • FxLaws and MonadLaws

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danimontoya this looks great, thank you!. Can you please Deprecate all the remaining binding operators and monad continuation types?

@danimontoya
Copy link
Contributor Author

thank you @raulraja ! I've just removed MonadContinuation and SuspendMonadContinuation and deprecated bind fun and ! operator and its usages in favor of invoke 👍

@raulraja raulraja marked this pull request as ready for review October 28, 2020 18:02
Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@rachelcarmena rachelcarmena merged commit f0c5dae into master Oct 28, 2020
@rachelcarmena rachelcarmena deleted the dm-refactor-continuations branch October 28, 2020 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants