This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KotlinX Coroutines throws
CancellationException
withcause
when propagating cancellation by exception fromasync
to it's parent. Since we cause theCancellationException
withShortCircuit
we need to look ifShortCircuit
can be found within the causes to return the excepted shifted value. If the cancellation is immediate, then it doesn't wrap inCancellationException
, that caused the test to be flaky. Now it passes consitently on a loop.Suspended computation blocks were running on
EmptyCoroutineContext
, they need to run on the parentsctx
to correctly propogate the state from outside to inside the computation block.