Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Deprecate IO (core docs) #275

Merged
merged 10 commits into from Dec 22, 2020
Merged

Deprecate IO (core docs) #275

merged 10 commits into from Dec 22, 2020

Conversation

raulraja
Copy link
Member

@raulraja raulraja commented Dec 19, 2020 •
edited

In preparation of the IO deprecation this PR removes and adapts examples using IO from the core repo.

@raulraja raulraja marked this pull request as draft December 19, 2020 18:36
@raulraja raulraja added the documentation Improvements or additions to documentation label Dec 19, 2020
@raulraja raulraja changed the title WIP - Deprecate IO Deprecate IO Dec 20, 2020
@raulraja raulraja requested a review from a team December 20, 2020 01:05
@raulraja raulraja marked this pull request as ready for review December 20, 2020 01:06
@raulraja raulraja changed the title Deprecate IO Deprecate IO (core docs) Dec 20, 2020
i-walker
i-walker approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@i-walker i-walker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raulraja, left only one question

nomisRev
nomisRev approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for cleaning this up!

@raulraja raulraja merged commit 9c50e8b into master Dec 22, 2020
@raulraja raulraja deleted the rr-deprecate-io branch December 22, 2020 16:21
@raulraja raulraja mentioned this pull request Dec 22, 2020
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pakoito pakoito pakoito left review comments

@nomisRev nomisRev nomisRev approved these changes

@i-walker i-walker i-walker approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raulraja @pakoito @nomisRev @i-walker