This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Move instances to typeclass #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
requested review from
franciscodr,
raulraja and
a team
and removed request for
franciscodr
franciscodr
reviewed
Jan 12, 2021
arrow-core/src/main/kotlin/arrow/core/extensions/ordering/eq/OrderingEq.kt
Outdated
Show resolved
Hide resolved
raulraja
approved these changes
Jan 12, 2021
…rderingEq.kt Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot guarantee that all data types have a
Companionobject, but we can guarantee that a typeclass has aCompanion. For consistency reason it's therefore most interessting to expose instances on theCompanionof the typeclass.This PR moves the new code that exposes the typeclasses to the typeclass Companion.