This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Deprecate map2 and product in favor of zip #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Iterable and Validated
raulraja
reviewed
Jan 21, 2021
arrow-core/src/main/kotlin/arrow/core/extensions/either/zip/EitherZip.kt
Outdated
Show resolved
Hide resolved
nomisRev
reviewed
Jan 22, 2021
Fix signature Either.zip Update `product3` with kotlin std Triple
nomisRev
reviewed
Jan 22, 2021
arrow-core/src/main/kotlin/arrow/core/extensions/option/zip/OptionZip.kt
Show resolved
Hide resolved
arrow-core/src/main/kotlin/arrow/core/extensions/option/zip/OptionZip.kt
Outdated
Show resolved
Hide resolved
…th zip definitions
# Conflicts: # arrow-core-data/src/main/kotlin/arrow/core/Either.kt # arrow-core/src/main/kotlin/arrow/core/extensions/list/apply/ListKApply.kt # arrow-core/src/main/kotlin/arrow/core/extensions/list/semigroupal/ListKSemigroupal.kt
i-walker
approved these changes
Jan 22, 2021
nomisRev
suggested changes
Jan 23, 2021
There was a problem hiding this comment.
Update deprecation message for map2 & product in EitherApply.kt is missing and then it LGTM.
Eval, Ior and NonEmptyList don't have map2, but we probably also need to define zip for them.
This may be added ehre or can be added in PRs for deprecating Eval, Ior and NonEmptyList.
nomisRev
approved these changes
Jan 25, 2021
It's better to derive it the other way around for performance reasons Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
|
Thanks @danimontoya! Great work 👏 👏 👏 |
franciscodr
approved these changes
Jan 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.clickup.com/t/cf2n35
Discussed here:
In Arrow we have following signatures for all data-types that implement
Apply:these should be deprecated towards new implementations which are the functions names from Kotlin Std